rules_nodejs icon indicating copy to clipboard operation
rules_nodejs copied to clipboard

optionsvalid.d.ts changes across machines

Open aptenodytes-forsteri opened this issue 3 years ago • 2 comments

Here, ts_project_options_validator.js writes process.argv[1] to the file:

https://github.com/bazelbuild/rules_nodejs/blob/43e478dd48cea53dbcc580da92ccb517534b832d/nodejs/private/ts_project_options_validator.js#L130

For us, this resolves to something like:

/home/jenkins_user/local-bazel-output-base/sandbox/linux-sandbox/9011/execroot/<workspace>/bazel-out/host/bin/external/path/to/ts_project_options_validator.js

So different build machines might populate the remote cache with different values, or local builds might unnecessarily differ from the remote cache. Does it make sense to remove this absolute path from the optionsvalid.d.ts file?

aptenodytes-forsteri avatar Apr 19 '22 13:04 aptenodytes-forsteri

Duplicate of https://github.com/bazelbuild/rules_nodejs/issues/3461

fparga avatar Jun 28 '22 03:06 fparga

Fixed by https://github.com/bazelbuild/rules_nodejs/pull/3462

Available in release 5.5.1

fparga avatar Jun 28 '22 03:06 fparga

Glad it's fixed!

aptenodytes-forsteri avatar Sep 28 '22 14:09 aptenodytes-forsteri