fix: symlink to runfiles only when running under ibazel

[thesayyn]

PR Checklist

Please check if your PR fulfills the following requirements:

• [ ] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• [ ] Bugfix
• [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
• [ ] Code style update (formatting, local variables)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Build related changes
• [ ] CI related changes
• [ ] Documentation content changes
• [ ] Other... Please describe:

What is the current behavior?

Linker links into runfiles which causes nodejs to load from multiple node_modules.

Issue Number: #3067

What is the new behavior?

Linker does not link into runfiles tree unless it runs under ibazel run which was the original intention of us to link into runfiles. (i need to confirm this with @gregmagolan)

Does this PR introduce a breaking change?

• [ ] Yes
• [x] No

Other information

[alexeagle]

I find it hard to believe there's behavior specific to ibazel run that wouldn't be the same as bazel run - it's just repeating the run more than once

[thesayyn]

I find it hard to believe there's behavior specific to ibazel run that wouldn't be the same as bazel run - it's just repeating the run more than once

That's true if the target has no ibazel_notify_changes tag. Here's the docs; https://github.com/bazelbuild/bazel-watcher#running-a-target and the logic seem to be put in there for an ibazel specific issue is what I understood from the comments above the logic.

[github-actions[bot]]

This Pull Request has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

[github-actions[bot]]

This PR was automatically closed because it went 30 days without any activity since it was labeled "Can Close?"