allow data input to go_proto_compiler

Open louisbuchbinder opened this issue 2 years ago • 2 comments

What type of PR is this? Feature

What does this PR do? Why is it needed? Currently the go_proto_compiler rule accepts custom proto compiler executables, but not the ability to pass custom input data in to the compiler runtime.

This change adds a data attribute to the go_proto_compiler rule. The data files provided are then appended to the input file list in the go.actions.run where the proto compiler is executed.

Which issues(s) does this PR fix?

Fixes https://github.com/bazelbuild/rules_go/issues/3732

Other notes for review Let me know what you are looking for regarding tests and I would be happy to add.

Oct 18 '23 16:10 louisbuchbinder

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Oct 18 '23 16:10 google-cla[bot]

Bumping this one. Please let me know if this change is acceptable

May 01 '24 20:05 louisbuchbinder