rules_foreign_cc
rules_foreign_cc copied to clipboard
Calls to `rm -rf` and `mkdir` are improperly quoted
Calls to rm -rf and mkdir, such as in rm -rf $BUILD_TMPDIR and mkdir -p $INSTALLDIR are not properly quoted and therefore do not handle paths containing spaces. I would go so far as to consider this a security issue, as the generated script may end up force-deleting any directory on a user's system for which it has permission to do so.
This issue is most apparent on Windows systems, where paths containing spaces are commonplace.
Discussion continues in https://github.com/bazel-contrib/rules_foreign_cc/pull/1389.