rules_foreign_cc icon indicating copy to clipboard operation
rules_foreign_cc copied to clipboard

Reopen: cmake_external does not handle source files with spaces

Open soro opened this issue 2 years ago • 1 comments

This is simply reopening issue https://github.com/bazelbuild/rules_foreign_cc/issues/542 The problem is definitely not fixed yet. I assume the error disappeared for the author of the original issue because they upgraded boost sufficiently to no longer encounter that erroneous file name. Unfortunately, we are stuck on a boost version that still has this file.

Error in fail: Wrong number (4) of arguments (("$$EXT_BUILD_ROOT$$/external/org_boost_boost/boost/serialization/collection_size_type", "copy.hpp", "$$EXT_BUILD_DEPS$$/include", "True")) in a call to 'symlink_contents_to_dir'

soro avatar Jan 02 '24 19:01 soro

Can you produce a minimal reproducer of this? Also what platform are you on as the toolchain for macos/linux/windows/freebsd for symlinking files is different on each of those OSes

jsharpe avatar Jan 17 '24 00:01 jsharpe

Unfortunately I don't really have time to minimize this and I've instead fixed it by updating to a newer boost version without this file

soro avatar Jul 01 '24 16:07 soro