rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

portable_mtime for py3_image

Open amir-f opened this issue 2 years ago • 1 comments

🚀 feature request

Description

When using py3_image the mtime (modification time) for all the files are set to 0 unix time (cira 1970). Some python libraries panic when they see that (eg. zipfile python builtin lib ValueError: ZIP does not support timestamps before 1980)

Describe the solution you'd like

container_image has an option to set all mtimes to a fixed valued: see portable_mtime but IIUC it needs to be routed to py3_image through the signatures somehow, hence this feature request.

Basically can we by default or through an option in py3_image set all the mtimes to something other than 0 ?

amir-f avatar Aug 19 '23 02:08 amir-f

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Dec 10 '24 02:12 github-actions[bot]