rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Add support for cred_helpers in push

Open titanous opened this issue 3 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #2109

What is the new behavior?

container_push now supports cred_helpers from the toolchain automatically.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

I'm out of my depth with the layers of indirection and nuances of Bazel rules so I'd like feedback on the approach before I finish this off by adding tests/docs.

titanous avatar Jun 26 '22 20:06 titanous

+1

loeffel-io avatar Jun 27 '22 07:06 loeffel-io

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Dec 25 '22 02:12 github-actions[bot]

Bump.

titanous avatar Dec 25 '22 02:12 titanous

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Jun 24 '23 02:06 github-actions[bot]

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Jul 25 '23 02:07 github-actions[bot]