container_push includes unnecessary uncompressed layers in runfiles since PR #1142

[zevdg]

🐞 bug report

Affected Rule

The issue is caused by the rule: container_push

Is this a regression?

Yes, the previous version in which this bug was not present was: v0.10.1

Description

contianer_push runfiles are significantly larger than necessary. In my case 2.7GB vs 900MB.

🔬 Minimal Reproduction

Just make a container_push and du -shL the runfiles directory.

🔥 Exception or Error

N/A

🌍 Your Environment

Operating System:

Output of bazel version:

N/A (blaze)

Rules_docker version:

Anything after v0.10.1

Anything else relevant? N/A

[zevdg]

I've already made a patch that addresses this by adding an include_uncompressed_layers boolean arg to generate_args_for_image and sets it to False in push.bzl. That was the most minimal version of the change I could make.

I could upstream that patch as-is, but it's a bit weird that the pusher's --layer arg requires you to pass in uncompressed layers and then totally ignores them. I could simply document that quirk and otherwise leave it as-is for consistency with the other tools, but maybe it shouldn't be using --layer syntax in the pusher and the digester since they only need the compressed subset. Any thoughts?

[zevdg]

just uploaded my patch as PR #2018. Happy to make any changes you would like to see.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

[github-actions[bot]]

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"