rules_android icon indicating copy to clipboard operation
rules_android copied to clipboard

Make mobile-install work with rules_jvm_external

Open fhilgers opened this issue 1 year ago • 2 comments

Possibly fixes #232

fhilgers avatar May 23 '24 15:05 fhilgers

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 23 '24 15:05 google-cla[bot]

The easier solution would probably be to set the package field of aar_import in rules_jvm_external. Should there maybe be a warning if that field is unset or if the package name inferred from field and label is empty?

fhilgers avatar May 24 '24 05:05 fhilgers

This should be resolved by https://github.com/bazelbuild/rules_android/commit/9e40a7875043d018f8a2e60ed0b5628f694d7b09.

ted-xie avatar Oct 17 '24 21:10 ted-xie