buildtools icon indicating copy to clipboard operation
buildtools copied to clipboard

No format for tabular data

Open systemlogic opened this issue 2 years ago • 5 comments

Not in all cases formatting of build data / code is required. Code can be written in a way which looks beautiful and easy to spot problem when maintained in tabular format using certain spacing between columns. Current implementation of buildfier results in loosing well formatted code( manually maintained) which has been needed in tabular code.

systemlogic avatar Nov 08 '23 18:11 systemlogic

This seems to change the whitespace of nearly every line. Did your editor save tabs as spaces?

aiuto avatar Nov 10 '23 22:11 aiuto

This seems to change the whitespace of nearly every line. Did your editor save tabs as spaces?

No such settings in my vim editor, which saves tabs as spaces.

However our own internal parser works with precision of spaces and all such tabular code need to be separated with spaces. In other words, no formatting from buildifier.

systemlogic avatar Nov 14 '23 04:11 systemlogic

@aiuto ping for review request.

systemlogic avatar Nov 21 '23 03:11 systemlogic

FWIW, we are using an internal version of #985. That patch needs to be rebased and reworked. Importantly for us it supports sorting by a particular column.

mzeren-vmw avatar Nov 28 '23 03:11 mzeren-vmw

@pmbethe09 @larsrc-google @vladmos @aiuto

I am curious to know if anything is pending?

systemlogic avatar Dec 01 '23 16:12 systemlogic