bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Prettify labels in action progress messages with Bzlmod

Open fmeum opened this issue 3 years ago • 4 comments

UiStateTracker is provided with the repository mapping of the main repository after the loading phase has been completed and uses this mapping to "unmap" canonical labels back to the apparent name used for them by the main repository.

fmeum avatar Dec 17 '22 20:12 fmeum

@Wyverald Could you review this PR?

@joeleba I have trouble getting UiStateTrackerTest to pass in the Skymeld case. This change makes it necessary to fire a LoadingPhaseCompleteEvent, but that seems to affect the SkymeldUiStateTracker state in a way I don't understand. Could you help with that?

fmeum avatar Dec 18 '22 10:12 fmeum

@zhengwei143 Could you please help with the failing test? Thanks!

joeleba avatar Dec 20 '22 12:12 joeleba

Seems like you just need to set mainRepositoryMapping = event.getMainRepositoryMapping(); in the SkymeldUiStateTracker#loadingComplete method. SkymeldUiStateTracker overrides that method - so the repository mapping wasn't set for the Skymeld case and hence you got a lot of NullPointerException(s) and failing tests.

zhengwei143 avatar Dec 20 '22 14:12 zhengwei143

@zhengwei143 Thanks, that seems to have worked, tests are passing now.

fmeum avatar Dec 20 '22 14:12 fmeum

@Wyverald Friendly ping

fmeum avatar Jan 03 '23 11:01 fmeum

@bazel-io flag

fmeum avatar Jan 04 '23 20:01 fmeum

@bazel-io fork 6.1.0

ShreeM01 avatar Jan 19 '23 07:01 ShreeM01