bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Support dict select union

Open AlessandroPatti opened this issue 3 years ago • 5 comments

Starlark has recentely added support for union operations over dictionaries (https://github.com/bazelbuild/starlark/pull/215). The syntax is already supported in bazel as of https://github.com/bazelbuild/bazel/pull/14540, but the same operation with selects of dictionaries is still usupported.

Related issue: #12457

AlessandroPatti avatar Mar 18 '22 14:03 AlessandroPatti

@tetromino Would you be able to review this? It's the reason why I worked on introducing the dict union operator in the first place.

fmeum avatar Apr 26 '22 14:04 fmeum

@comius AFAIK tetromino won't be available until July. Is there anybody else who could take over the review?

fmeum avatar May 21 '22 17:05 fmeum

@fmeum @tetromino @comius Any update on this? I'd be awesome to have it in the next release

AlessandroPatti avatar Jun 29 '22 11:06 AlessandroPatti

@AlessandroPatti Not a Googler, so I can't do more than stating that this LGTM.

@brandjon Do you happen to have cycles to get this into 5.3.0?

fmeum avatar Jul 07 '22 08:07 fmeum

@comius @tetromino Friendly ping. This has been in review for almost half a year now, it would be great to finally get it merged.

fmeum avatar Aug 03 '22 18:08 fmeum

@comius @tetromino @gregestren Friendly ping, is there any blocker for merging this?

AlessandroPatti avatar Aug 18 '22 08:08 AlessandroPatti

My apologies for the very late review!

tetromino avatar Aug 18 '22 19:08 tetromino