bastibe
Added 'Orientation' parameter for vertical and horizontal layouts
Hm, merging and resolving conflicts is still pretty new to me. I gave it my best. Also I have addressed all of your comments. Let me know if everything fits now, else I will try to fix it asap. I was also thinking of including that 'parent' property which you discussed in the other PR.
I also don't know whether you saw that I made changes to violinplot.m as well. I hope those are fine as well.
Should be done and ready to merge. Do you want to also add the 'parent' property from #24 ? Should be an easy inclusion.
Do you want to also add the 'parent' property from https://github.com/bastibe/Violinplot-Matlab/pull/24 ?
That would be a good idea, thank you!
I have added now the parent property and checked the functionality of the orientation swap and the 'parent' axis in a modified testviolinplot.m. To me it looks like it works fine.
Looks good to me! Thank you!
If you want to, you could add an example to the README.
Is this ready to merge on your end?
Yeah on my end it should be ready. However, if you want me to add an example in the README, then we should maybe wait with merging. The same goes for the testviolinplot.m. I could add some tests to facilitate any future PR don't create problems with the two new features.
I have edited the README and the readme_figures.m respectively. The README now shows a code snippet that can work on its own, which the previous one couldn't. I have also added two new test cases into testviolinplot.m which test the 'Parent' and 'Orientation' property. Feel free to merge it into the main branch as you like.