Matthias Langer
Matthias Langer
@rhdong I changed the PR. See this as part 1 of the GDS interface . The external storage interface as specified now, will be used by the feeding process.
RocksDB is downgraded to version 6.29 because that is the last version that doesn't yet require C++17.
Long necessary change and step 1 in order to fix: https://github.com/NVIDIA-Merlin/HierarchicalKV/issues/126
Rebased to master.
Step 2 in to actually fix: https://github.com/NVIDIA-Merlin/HierarchicalKV/issues/126
Updated.
I just tested it with a bunch of more complex things. The functions still work. But inlining could be much better. Would it be possible to apply an optimizer?
@rklaehn: I kind of agree. Otherwise you would probably have to mimic floating point exceptions. By just encoding/decoding on the fly, you avoid most of that hazzle. We just have...
For the encoding/decoding part. I found this guy who almost managed to do the wrapping properly in C#: http://codereview.stackexchange.com/questions/45007/half-precision-reader-writer-for-c Same for Java: http://stackoverflow.com/questions/6162651/half-precision-floating-point-in-java/6162687#6162687 Some more info about the conversion process:...
Thanks, you guys are great!