Add Link then Undo Leaves Behind Background Color Highlight

[chadrschroeder]

1. Select text.
2. Click the link icon and apply a link.
3. Click the undo button.

This leaves behind a span with background-color: highlight;. If you have a background color picker, that can be used to remove the color. Otherwise, you have to delete the selection and re-enter it to get the highlighting to go away.

When the editor opens a dialog it calls freezeSelection it uses the frozen attribute which uses a background color of highlight. When the dialog is recording the undo entry recordUndoEntry -> createEntry -> this.composition.getSnapshot() gets the current snapshot of the rich text which includes attributes that include "frozen": true.

Maybe getSnapshot should ignore the frozen attribute since that's an internal attribute that is only used to keep the selected text highlighted while the dialog is open?

One way to work around the issue is to disable the frozen attribute during the trix-before-initialize event with:

Trix.config.textAttributes.frozen = {}

Details

• Trix version: 2.0.5

[moladukes]

How do you change this background color of the selection UI? I think it would be cleaner if it was wrapped in a tag which could be styled in CSS and is a bit more semantic.

Sorry if this is unrelated but found this issue trying to figure out how to change the style of it.