Walker: migrate to 1.0.0-beta

[abenz1267]

I think i've setup everything needed, but since I don't run omarchy I can't fully confirm. So please test.

[ryanrhughes]

Sounds like a great reason to make the jump over to Omarchy @abenz1267. 😉

Thanks for doing this though. I'll pull this down and put it through some paces to see if I find anything.

[abenz1267]

i've actually removed the dmenu and keybindings themes. i don't think they are needed.

[dhh]

I just pulled this to give it a try. Maybe there's something wrong with the migration?

[abenz1267]

this looks you are still on walker 0.13.*

[dhh]

Yeah, I am. I get:

omarchy walkermigration * ❯ walker --version
Running Service: false
0.13.26

Ahh, I think it's because there's a rust conflict:

looking for conflicting packages...
:: rustup-1.28.2-3 and rust-1:1.89.0-1 are in conflict. Remove rust? [y/N]
error: unresolvable package conflicts detected
error: failed to prepare transaction (conflicting dependencies)
:: rustup-1.28.2-3 and rust-1:1.89.0-1 are in conflict
 -> Failed to install layer, rolling up to next layer.error:error installing repo packages
:: Synchronizing package databases...
 core is up to date
 extra is up to date
 multilib is up to date
 chaotic-aur is up to date
resolving dependencies...
looking for conflicting packages...
:: rustup-1.28.2-3 and rust-1:1.89.0-1 are in conflict. Remove rust? [y/N]
error: unresolvable package conflicts detected
error: failed to prepare transaction (conflicting dependencies)
:: rustup-1.28.2-3 and rust-1:1.89.0-1 are in conflict
 -> error installing repo packages
error installing repo packages

[dhh]

Removed rust, but we need a better solution for that, I think. Also seeing this when it's compiling:

[dhh]

Got it installed, but it fails to launch with:

[dhh]

Ran the migration again, and getting this:

[abenz1267]

fixed the theme thingy. also updated the aur package to use rust instead of rustup.

[dhh]

Style needs a bit of work to match what we had. This is how it looks out of the box. It's not tall enough (so there's scrolling), it's got a blinking cursor:

And it's got a flash when you jump between menus that wasn't there before either.

The dynamic Font menu isn't working. It's under Style > Font. Same with the dynamic theme menu.

[dhh]

Actually, I guess we always had a blinking cursor! What are missing is the "Go..." placeholder for typing. Here's what the current menu looks like:

[abenz1267]

fixed walker for the -p parameter... menu should be bigger now as well.

[dhh]

Thanks for working on this! As soon as AUR is back, I'll test more. Would make it a bit easier to review the diff if we could keep the indention (2 spaces) the same as it was (and same as rest of the project).

[abenz1267]

fixed it. i've also added .editorconfig files ...

[jamesmcm]

@dhh for the Rust issue I think we can switch to install the rustup version of Rust? This is also what Rust developers would want anyway.

I think we just need to install rustup instead of rust and then initialise it with the stable toolchain: rustup default stable - this would then make it easy to install rust-analyzer, rustfmt, etc. for development, as in https://wiki.archlinux.org/title/Rust

(assuming walker doesn't require nightly)

[dhh]

Please do explore that change. Should run rust as rusticians would want it!

[abenz1267]

I think omarchy should install rustup instead of rust. But still the AUR package is broken. I will fix it. It shouldn't rely on rustup OR rust, but cargo.

[ahowardm]

@ryanrhughes to help you with indentation I made this PR: https://github.com/basecamp/omarchy/pull/1706

[dhh]

First thing I saw after migrating was this:

[dhh]

I fixed the migration to use omarchy-refresh-walker, to get the latest config, and that fixed it.

But the UI still isn't quite right. The not-found state expands the box weirdly sideways. The submenus have too much dead space beneath them. They need to be capped to just the length of the items.

https://github.com/user-attachments/assets/299c11c7-2a02-4067-bfa8-10cbc5802950

[dhh]

The highlight is also too pronounced. It should just be italic:

[dhh]

The app launcher isn't working out the box:

[abenz1267]

styling should be fixed.

[dhh]

I'm still seeing the oversized menus:

The menu is now better when it doesn't find results, but it now shrinks instead of supersizes. It needs to stay the same size and "No Results" should be up at the top like it was before:

https://github.com/user-attachments/assets/d69474cc-c2f3-4b45-a86b-d6ca84932cb5

[dhh]

The app launcher search also seems to be busted:

[dhh]

Actually, looks like it was always busted. It ought only to find complete words or word fragments:

[abenz1267]

Walker generally searches app titles, keywords and descriptions. And weights those. F.e.

The "problem" is that omarchy hides the subtext, so indeed a "why does it match?" might arise. But it always did that. I'd add an option to NOT search keywords/comment/description.

[dhh]

Just managed to get the opposite of too large of a box. Now it's too small. Not sure what triggered it:

[abenz1267]

i had to push a little rework in regards to how walker handles -w/-h flags, so update pls. also added the option for elephant to only search for titles and not categories/keywords/comments.

should be updated in the aur in a few minutes.

adjusted the styling to reflect the changes... let me know if it's correct now or still wonky.

[abenz1267]

you dont want the keybind hints at the bottom?