barcode-java icon indicating copy to clipboard operation
barcode-java copied to clipboard

The LabelPositions.TOP does not work.

Open EircYangQM opened this issue 3 years ago • 2 comments

The line 914 in barcode.java.

if ((getLabelPosition().ordinal() & Labels.LabelPositions.TOP.ordinal()) > 0)

Labels.LabelPositions.TOP.ordinal() is 0, So it is always 0. Maybe we just check the enum not enum's value.

EircYangQM avatar Jul 10 '22 08:07 EircYangQM

Care to create a PR?

barnhill avatar Jul 10 '22 14:07 barnhill

I add the PR. please check this.

EircYangQM avatar Jul 14 '22 10:07 EircYangQM

This was addressed in https://github.com/barnhill/barcode-java/pull/19. Closing.

barnhill avatar Jun 03 '23 17:06 barnhill