nodebb-plugin-imgur
nodebb-plugin-imgur copied to clipboard
Vulnerability through remote upload
Currently it is not possible to either, set a proxy for remote file uploads nor to disable remote file uploads if using this plugin.
This opens a vulnerability that discloses the server ip to an attacker in a reverse proxy setup.
Currently the only condition to trigger this seems just to be the upload plugin, but not any realy settings.
<!-- IF config.hasImageUploadPlugin -->
<div class="btn-group" role="group">
<button type="button" class="btn btn-default" data-action="upload-url">[[user:upload_new_picture_from_url]]</button>
</div>
<!-- ENDIF config.hasImageUploadPlugin -->
The same goes for the upload function itself:
if (!plugins.hasListeners('filter:uploadImage')) {
return callback(new Error('[[error:no-plugin]]'));
}
Notes to this, this is a very known and common attack pattern for a very common protection scenario against DDoS.