typescript icon indicating copy to clipboard operation
typescript copied to clipboard

not compatible with recent "@babel/runtime"

Open zetekla opened this issue 6 years ago • 5 comments

Can you extend support for "@babel/runtime": "7.4.0" ?

When I have my tsconfig.json like this and "@babel/runtime": "7.0.0-beta.39", my Meteor project works but when I upgrade to 7.1.0 and 7.4.0 it breaks

{
  "compilerOptions": {
    "baseUrl": "./",
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "module": "commonjs",
    "moduleResolution": "node",
    "skipLibCheck": true,
    "allowSyntheticDefaultImports": true,
    "sourceMap": true,
    "allowJs": true,
    "jsx": "react",
    "alwaysStrict": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "rootDir": "src",
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": true,
    "types": ["meteor-typings", "node", "node_modules/@types"],
    "paths": {
      "@imports/*": ["imports/*"]
    }
  },
  "include": [
    "client/**/*",
    "server/**/*",
    "imports/**/*"
  ],
  "exclude": [
    "node_modules",
    ".meteor"
  ],
  "files": [
    "typings/index.d.ts"
  ]
}

Also, I cannot add "esModuleInterop": true, and "resolveJsonModule": true, my app just no longer works when I added these lines.

zetekla avatar Mar 21 '19 03:03 zetekla

Relatedly, I tried to use the TypeScript 2.9 "resolveJsonModule": true compiler option and got the following error since this package is still based on TypeScript 2.8.3.

=> Errors prevented startup:
   
   While processing files with barbatus:typescript (for target web.browser):
   packages/barbatus:typescript-compiler/typescript-compiler.js:294:13: Format
   of the tsconfig is invalid: Error: Unknown compiler option
   'resolveJsonModule'.
   at TypeScriptCompiler._parseConfig
   (packages/barbatus:typescript-compiler/typescript-compiler.js:294:13)
   at TypeScriptCompiler._processConfig
   (packages/barbatus:typescript-compiler/typescript-compiler.js:262:32)
   at TypeScriptCompiler.getBuildOptions
   (packages/barbatus:typescript-compiler/typescript-compiler.js:82:10)
   at TypeScriptCompiler.processFilesForTarget
   (packages/barbatus:typescript-compiler/typescript-compiler.js:105:26)

KeithGillette avatar Mar 26 '19 14:03 KeithGillette

Without understanding your issue: try https://atmospherejs.com/adornis/typescript , we forked and are using the newest version of TypeScript, maybe it helps.

yorrd avatar Mar 26 '19 19:03 yorrd

Thanks, @yorrd! In looking elsewhere, I stumbled across your fork and tried it. However, I could not get that package to work without manual work-arounds.

KeithGillette avatar Mar 26 '19 19:03 KeithGillette

@KeithGillette let's continue conversation over there

yorrd avatar Mar 26 '19 19:03 yorrd

@KeithGillette I think for your specific problem, you should use/update your repo with more recent typescript version. Mine is the incompatibility between @babel/runtime and typescript configs (tsconfig.json) to support a Meteor + React app.

zetekla avatar Apr 13 '19 01:04 zetekla