bangumi
feat(collection): generate a timeline when patch collection
Deploy Preview for bangumi-org-server ready!
| Name | Link |
|---|---|
| Latest commit | 55512a9fb9bb0fd3998fc4636e1807e555734a1c |
| Latest deploy log | https://app.netlify.com/sites/bangumi-org-server/deploys/635650cc0c5b3100093214ea |
| Deploy Preview | https://deploy-preview-217--bangumi-org-server.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Base: 49.68% // Head: 50.04% // Increases project coverage by +0.35% :tada:
Coverage data is based on head (
9074bdd) compared to base (d07f426). Patch coverage: 82.45% of modified lines in pull request are covered.
:exclamation: Current head 9074bdd differs from pull request most recent head 55512a9. Consider uploading reports for the commit 55512a9 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 49.68% 50.04% +0.35%
==========================================
Files 197 198 +1
Lines 7797 7847 +50
==========================================
+ Hits 3874 3927 +53
+ Misses 3467 3461 -6
- Partials 456 459 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/model/subject.go | 44.44% <ø> (ø) |
|
| internal/model/timeline.go | 32.35% <ø> (+32.35%) |
:arrow_up: |
| internal/pkg/generic/math.go | 0.00% <ø> (ø) |
|
| main.go | 0.00% <ø> (ø) |
|
| internal/pkg/generic/conv.go | 62.50% <62.50%> (ø) |
|
| internal/ctrl/update_subject_collection.go | 68.14% <82.50%> (+6.04%) |
:arrow_up: |
| internal/ctrl/ctrl.go | 100.00% <100.00%> (ø) |
|
| internal/subject/mysql_repository.go | 58.08% <100.00%> (+0.25%) |
:arrow_up: |
| internal/timeline/image/image.go | 73.64% <100.00%> (ø) |
|
| internal/timeline/mysql_repository.go | 50.40% <100.00%> (ø) |
|
| ... and 3 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
https://gist.github.com/Trim21/efcaad5233b08019b292615bd146b8a1 https://gist.github.com/Trim21/b930f98e000c7024b41de74f92d192aa
旧站好像不只检查上一条，会检查上一条同类的时间线然后修改。
在x集上点看到
设置完成度，会改写上一条时间线，就算中间插一条非同类时间线（吐槽）也会这样。
（忽略截图里的时间）
https://gist.github.com/Trim21/efcaad5233b08019b292615bd146b8a1
这里只有 subject 中插入 timeline 的代码，有没有 collection 的？
https://gist.github.com/Trim21/b930f98e000c7024b41de74f92d192aa#file-timeline-php-L668-L688
这里的获取用户端类型在重构版中有对应的函数吗
https://gist.github.com/Trim21/b930f98e000c7024b41de74f92d192aa#file-timeline-php-L668-L688
这里的获取用户端类型在重构版中有对应的函数吗
没有
还有些函数命名之类的要修修，剩下的都挪到后续的 mr 里做比较好：type progress 的时间线 / timeline.Create 合并 batch 时间线