hacktribe icon indicating copy to clipboard operation
hacktribe copied to clipboard

IFX edit parameter not recalled correctly on FX type change after pattern change.

Open BKLronin opened this issue 4 years ago • 10 comments

When using the lag effect on asnare for groove purposes, it seems the it gets quantized later as the set value. The value itself is correctly safed and after setting to orig value the timing is correct again.

BKLronin avatar Nov 25 '21 22:11 BKLronin

Can confirm, will investigate.

bangcorrupt avatar Nov 25 '21 22:11 bangcorrupt

This may have to wait until I get a debugger attached to the DSP. ~~It looks like it's returning to the default value in the effect unit definition.~~ Will require stepping through to see how the DSP code handles the data sent from the CPU.

bangcorrupt avatar Nov 26 '21 17:11 bangcorrupt

Ok cool, I´m just making some beats currently to test all functions.

BKLronin avatar Nov 26 '21 17:11 BKLronin

Is it just me or is the recording quantization much finer? I can remember quantizing almost all of my grooves out in the original fw. (not IFX related)

BKLronin avatar Nov 26 '21 18:11 BKLronin

Shouldn't be any difference. If you're not using any groove template or swing, everything should be grid locked.

bangcorrupt avatar Nov 26 '21 18:11 bangcorrupt

Ok, just placebo or my timing got more conventional recently :D

The lag ifx is pretty nice for that. LIttle more natural to dial in other than the grooves.

BKLronin avatar Nov 26 '21 18:11 BKLronin

It looks like all IFX are being reset to Edit value of 64. Probably missed updating a pointer somewhere.

bangcorrupt avatar Nov 27 '21 13:11 bangcorrupt

At least for lag and overdrive the orig value when loading the pattern is correctly safed but I have to manually move it to this position where it shows "orig". Thats not the case for one of the filterdrivers they have the 64 orig value as you have said.

BKLronin avatar Nov 27 '21 15:11 BKLronin

a939c6a ~appears to recall IFX Edit values correctly~

Not entirely fixed.

bangcorrupt avatar Nov 27 '21 18:11 bangcorrupt

  1. Set IFX type to 'LP Drive'
  2. Set IFX Edit to minimum
  3. Save pattern
  4. Increment pattern
  5. Decrement pattern
  6. IFX Edit value is recalled correctly
  7. Increment IFX Type
  8. Decrement IFX Type
  9. IFX Edit has returned to default 64 <-- Error
  10. Set IFX Edit to minimum
  11. Increment IFX Type
  12. Decrement IFX Type
  13. IFX Edit value is recalled correctly

Find missed index and set to IFX max count.

bangcorrupt avatar Jan 15 '22 23:01 bangcorrupt