open-source icon indicating copy to clipboard operation
open-source copied to clipboard

Get feedback from participants from onboarding / application : https://github.com/baloise-incubator/

Open MarkusTiede opened this issue 5 years ago • 11 comments

From

  • [x] @ArthurNeudeck - https://github.com/baloise-incubator/org/pull/9
  • [ ] @Trieda - https://github.com/baloise-incubator/org/pull/13
  • [ ] @mikevader
  • [ ] @tommuelli
  • [ ] @chris-lipp

MarkusTiede avatar Aug 27 '20 09:08 MarkusTiede

The agreement is quite extensive and I was wondering whether we might shorten it: the longer the less it will be read.

ArthurNeudeck avatar Sep 04 '20 10:09 ArthurNeudeck

The document has many links/ URLs/ references: reading it always forces you to either follow a link or keep on reading. I guess I would prefer for internal links a separate "(see chapter , )" and for external links (see <external reference)".

ArthurNeudeck avatar Sep 04 '20 10:09 ArthurNeudeck

Explanations and demands are cool - I was actually wondering, whether some checks can be done automatically such as "no passwords/ secrets" or avoiding "personal/ personalized data" being plugged in as hooks?

ArthurNeudeck avatar Sep 04 '20 10:09 ArthurNeudeck

We might add ArchUnit in the template to avoid referencing internal infrastructure?

ArthurNeudeck avatar Sep 04 '20 10:09 ArthurNeudeck

I got the impression that some topics are redundant in the document such as "get a review". I would rather leave it at one central location, i.e. where we describe the process.

ArthurNeudeck avatar Sep 04 '20 10:09 ArthurNeudeck

Chapter 4.1: a brief description of roles would be nice

ArthurNeudeck avatar Sep 04 '20 12:09 ArthurNeudeck

Figure 4: I guess the license name is missing in the caption

ArthurNeudeck avatar Sep 04 '20 12:09 ArthurNeudeck

Chapter 1.1; could not really get heading vs contents ;)

ArthurNeudeck avatar Sep 04 '20 12:09 ArthurNeudeck

As far as I can remember there does exist a certain set of rules for headings in English (i.e. most words start with a capital letter).

ArthurNeudeck avatar Sep 04 '20 12:09 ArthurNeudeck

Chapter 2: do you really have to repeat "open source" in any title? I guess that is what the whole document is about.

ArthurNeudeck avatar Sep 04 '20 12:09 ArthurNeudeck

Conclusion: i like the contents of the document very much - or even better: the attitude it provides. I asked myself whether it must be in a "list of guidelines" style or it might be a more process oriented way: you want to start open source? Here is what you need to do, what you need to take into concern, and who may assist you. But: Definitely something I can and will sign and follow. Good work!

ArthurNeudeck avatar Sep 04 '20 13:09 ArthurNeudeck