ESP_VS1053_Library icon indicating copy to clipboard operation
ESP_VS1053_Library copied to clipboard
verified publisher icon baldram

Ring buffer demo

Open fabitom opened this issue 5 years ago • 3 comments

Here is simple ring buffer demo based on Edzelf/ESP32-Radio

fabitom avatar Apr 14 '20 14:04 fabitom

@fabitom Thank you for the PR. Is your feature branch merged with the latest master? I see file changes from the other PR which is already merged to master. So it's some extra noise in this PR. I know it will be theoretically ignored while merging.

baldram avatar Apr 14 '20 18:04 baldram

right, I just made ring-buffer-demo branch based on previous. But there was no changes. Should I fork again ? what is right way ? I'm not an expert git ;(

fabitom avatar Apr 14 '20 19:04 fabitom

Should I fork again ? what is the right way?

Definitely not. Just merge the stuff from master to your feature branch. It would be something like described here. So the point 1 of this answer. The "feature" is your branch "ring-buffer-demo". Please do a local backup of the folder ;-) Nothing wrong should happen, just in case.

Github describes it also here, but I guess you don't use this GithubDesktop whatever it is.

PS: After all, the PR should be updated, of course.

baldram avatar Apr 14 '20 21:04 baldram