cypress-split icon indicating copy to clipboard operation
cypress-split copied to clipboard

cypress-split always uses average duration

Open KleaTech opened this issue 1 year ago • 5 comments

cypress-split finds and reads the timings file correctly, but cannot find the individual specs in it. The reason is that the path in the timings file and the path that cypress-split compares with are different, see image.

image

KleaTech avatar Apr 12 '24 11:04 KleaTech

I think this solves it, but probably it would make sense to revisit the specAbsoluteToRelative approach

image

KleaTech avatar Apr 12 '24 11:04 KleaTech

Mind opening a PR with a test that shows the problem and the fix?Sent from my iPhoneOn Apr 12, 2024, at 07:49, Adam Bozzay @.***> wrote: I think this solves it, but probably it would make sense to revisit the specAbsoluteToRelative approach image.png (view on web)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

bahmutov avatar Apr 12 '24 11:04 bahmutov

I check if I can write a test that indicates the issue.

The fix I suggested works, but I think it's more of a workaround. It's even possible that the best place for the fix is in find-cypress-specs.

KleaTech avatar Apr 12 '24 12:04 KleaTech

Any luck with this one ? :) hitting same thing.

dwilson0806 avatar Oct 17 '24 09:10 dwilson0806

Hey, @bahmutov 👋

The issue is still relevant.

I am currently investigating the timings.json feature.

I am using the test analytics db query to prepare timings.json file, all files have different values in the output json, I tried first to plug this file on CI and haven't noticed any changes, so checked logs and reproduced the problem locally, proof with logged equal values:

Image

Any opportunity to review and release the plugin new version with the @KleaTech suggested fix 🔝 ?

lashchanka avatar Feb 25 '25 18:02 lashchanka