corebird icon indicating copy to clipboard operation
corebird copied to clipboard

conversation order is wrong if the initial tweet is a retweet

Open baedert opened this issue 8 years ago • 5 comments

For example: https://paste.xinu.at/p1H3i/

The retweet that is the topmost tweet in the lower list box should actually be at the bottom.

baedert avatar Jul 23 '17 18:07 baedert

Okay the screenshot is gone and I can't reproduce the issue right now at all.

baedert avatar Aug 05 '17 09:08 baedert

I can't reproduce this issue either.

Vistaus avatar Aug 14 '17 11:08 Vistaus

Let's just close it for now.

baedert avatar Aug 19 '17 06:08 baedert

Proof that this is a thing: https://my.mixtape.moe/fvwzje.webm

Just need to find time now to find out what's wrong + fix.

baedert avatar Aug 24 '17 11:08 baedert

Heh. It's actually all technically correct. This problem happens when the three tweets are created in the following order:

  1. The actual tweet
  2. The reply to 1)
  3. The retweet of 1)

Now, the TweetInfoPage will show the replies to the original tweet, i.e. 1) and not to the retweet. However, when both 2) and 3) are in the lower listbox together, the underlying model will sort them after their source ID (which is what makes sense in the home timeline, basically) and so the newer retweet will be on top and the older reply will be at the bottom.

baedert avatar Aug 24 '17 12:08 baedert