Add a button to hide the retweets in home/lists

[juanfra684]

I would like to hide the retweets in some lists. Can you add an option in the settings to hide the retweets?. IIRC, internally corebird only needs to add a new parameter to the API url: include_rts=false.

[juanfra684]

I'm using this patch to hide the retweets. Here is the API doc https://dev.twitter.com/docs/api/1.1/get/lists/statuses.

--- src/ListStatusesPage.vala.orig  Fri Jul 25 04:12:58 2014
+++ src/ListStatusesPage.vala   Fri Jul 25 04:17:40 2014
@@ -156,6 +156,7 @@ class ListStatusesPage : ScrollWidget, IPage {
     call.set_method ("GET");
     debug ("USING LIST ID %s", list_id.to_string ());
     call.add_param ("list_id", list_id.to_string ());
+    call.add_param ("include_rts", "false");
     call.add_param ("count", "25");
     try {
       yield call.invoke_async (null);
@@ -196,6 +197,7 @@ class ListStatusesPage : ScrollWidget, IPage {
     call.set_method ("GET");
     call.add_param ("list_id", list_id.to_string ());
     call.add_param ("max_id", (lowest_id -1).to_string ());
+    call.add_param ("include_rts", "false");
     call.add_param ("count", "25");
     try {
       yield call.invoke_async (null);
@@ -316,6 +318,7 @@ class ListStatusesPage : ScrollWidget, IPage {
     call.set_function ("1.1/lists/statuses.json");
     call.set_method ("GET");
     call.add_param ("list_id", list_id.to_string ());
+    call.add_param ("include_rts", "false");
     call.add_param ("since_id", max_id.to_string ());
     message (@"Using max_id $max_id");
     try {

[juanfra684]

Do you have planned to add this feature?. I've been patching corebird for more than 3 years. For me, this is the only missing feature of the client.

If adding a per list option is a problem, you could also add just a global option.

[baedert]

Do you have planned to add this feature?

Nope

I've been patching corebird for more than 3 years.

And still I don't see a pull request with your name on it. Obviously this would have to be toggle-able per list and then you have to refetch everything (or always fetch with rts and then hide them) and it gets more complex when scrolled down I think.

[juanfra684]

Unfortunately, I don't know how to program with vala. That's why I didn't send a pull request.

I was thinking in something like this: add call.add_param ("include_rts", somevariable); to every call with true as default. When the user toggles the button, change somevariable to false, discard the old data and refresh the view.

[Vistaus]

You say you patch it, you show us what to me looks like a patch in Vala (correct me if I'm wrong) and then you say you don't know how to program in Vala?

[juanfra684]

I changed the URL. That's all :)