shields icon indicating copy to clipboard operation
shields copied to clipboard

Add [galaxytoolshed] Version

Open guillaume-gricourt opened this issue 3 years ago • 4 comments

Hi, This PR adds a feature to the galaxytoolshed service. Referring to https://github.com/badges/shields/issues/7660. The schema is updated, I hope there is no mistake about its construction. Many thanks

guillaume-gricourt avatar Jul 26 '22 09:07 guillaume-gricourt

Messages
:book: :sparkles: Thanks for your contribution to Shields, @guillaume-gricourt!

Generated by :no_entry_sign: dangerJS against 1c29948334b14f76c118713e49690b85e04b3dc1

shields-ci avatar Jul 26 '22 09:07 shields-ci

Thank you for the PR! I recognize that we probably discussed this previously on other PRs, but I think it would be helpful if you could articulate what these badges are/what they look like here inline for greater visibility

calebcartwright avatar Jul 30 '22 21:07 calebcartwright

Yeah of course, There are 3 layers:

  • the repository (head of the structure) has a version number changeset_revision
  • One repository has zero or some tools, with a version number for each one. It can be identified with its name. Field valid_tools in the schema.
  • A tool may have zero or some requirements (other tools), with a version number for each one. It can be identified with its name. Field requirements in the schema. Is it more clear ?

guillaume-gricourt avatar Aug 01 '22 16:08 guillaume-gricourt

Thanks, though I was actually thinking more along the lines of the types of things we ask for/discuss when new badges are requested (e.g. https://github.com/badges/shields/issues/new?assignees=&labels=service-badge&template=3_Badge_request.md)

Some of those items are already inherent, but it would be good if you could demonstrate the different variants of badges that would be displayed along with an associated "why" for each one

calebcartwright avatar Aug 06 '22 02:08 calebcartwright

Messages
:book: :sparkles: Thanks for your contribution to Shields, @guillaume-gricourt!

Generated by :no_entry_sign: dangerJS against 7d675614b3ad7b7f3095c3da53f550e5c461ec37

github-actions[bot] avatar Jan 04 '24 10:01 github-actions[bot]

🚀 Updated review app: https://pr-8249-badges-shields.fly.dev

github-actions[bot] avatar Jan 04 '24 20:01 github-actions[bot]

We're almost there! When searching for the new badges, it's not obvious that they are version badges: Screenshot 2024-01-04 211604

I suggest adding "Version" to the title of the new badges, for example Galaxy Toolshed - Tool Version.

PyvesB avatar Jan 04 '24 20:01 PyvesB