WIP detect ipv6 dest addr and pass with [] to rsync

[tesshuflower]

Signed-off-by: Tesshu Flower [email protected]

Describe what this PR does Rsync if provided with an IPv6 address needs to use the address in the format [ipv6addr]. This is a URL format.

In the mover script, attempt to detect if the destination address is an ipv6 address and wrap with [] only if it does not already contain []. This hopefully avoids issues with urls that are already formatted correctly.

Is there anything that requires special attention?

• Crude ipv6 check - checking that there are enough stanzas with : (or :: is found)
• Also avoids wrapping with [] if the address already contains [] - potentially could happen with a url address that embeds an ipv6 address?

Related issues: https://github.com/backube/volsync/issues/402

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [tesshuflower]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[codecov[bot]]

Codecov Report

Merging #405 (26262aa) into main (066f018) will increase coverage by 0.1%. The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #405     +/-   ##
=======================================
+ Coverage   64.1%   64.2%   +0.1%     
=======================================
  Files         44      45      +1     
  Lines       5171    5236     +65     
=======================================
+ Hits        3317    3364     +47     
- Misses      1657    1671     +14     
- Partials     197     201      +4     

Impacted Files	Coverage Δ
controllers/utils/affinity.go	85.5% <0.0%> (-1.8%)	:arrow_down:
controllers/platform/properties.go	67.4% <0.0%> (ø)

[tesshuflower]

/cc @JohnStrunk

John, do you mind taking a look at this? I wasn't able to get an easily accessible ipv6 env so haven't re-tested, but have been using this patch in other non-ipv6 rsync tests.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[JohnStrunk]

/lgtm

[tesshuflower]

/cherrypick release-0.5

[openshift-cherrypick-robot]

@tesshuflower: new pull request created: #437

In response to this:

/cherrypick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.