community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

Feature/migrate-time-saver-workspace

Open ionSurf opened this issue 1 year ago • 5 comments

Hey, I just made a Pull Request!

Provides time-saver plugins migration.

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [x] Added or updated documentation
  • [x] Tests for new functionality and regression tests for bug fixes
  • [x] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

ionSurf avatar Aug 16 '24 22:08 ionSurf

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-catalog-backend-module-time-saver-processor
  • @backstage-community/plugin-time-saver-backend
  • @backstage-community/plugin-time-saver-common
  • @backstage-community/plugin-time-saver

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-catalog-backend-module-time-saver-processor workspaces/time-saver/plugins/catalog-backend-module-time-saver-processor none v1.1.0
@backstage-community/plugin-time-saver-backend workspaces/time-saver/plugins/time-saver-backend none v3.0.0
@backstage-community/plugin-time-saver-common workspaces/time-saver/plugins/time-saver-common none v0.4.0
@backstage-community/plugin-time-saver workspaces/time-saver/plugins/time-saver none v1.3.0

backstage-goalie[bot] avatar Aug 16 '24 22:08 backstage-goalie[bot]

Thanks for the contribution! All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

backstage-goalie[bot] avatar Aug 16 '24 22:08 backstage-goalie[bot]

Hi @ionSurf, this plugin was created by @tduniec, could you provide a bit more details as to the background of this migration? I would have expected this more to be done by @tduniec, has the plugin gone unmaintained? If so we generally like to have an issue where we request moving the plugin in the source repo and also include an attribution to the original author for example like this: https://github.com/backstage/community-plugins/tree/main/workspaces/grafana/plugins/grafana#special-thanks--disclaimer

awanlin avatar Aug 18 '24 20:08 awanlin

Hi @ionSurf, this plugin was created by @tduniec, could you provide a bit more details as to the background of this migration? I would have expected this more to be done by @tduniec, has the plugin gone unmaintained? If so we generally like to have an issue where we request moving the plugin in the source repo and also include an attribution to the original author for example like this: https://github.com/backstage/community-plugins/tree/main/workspaces/grafana/plugins/grafana#special-thanks--disclaimer

@ionSurf is added as maintainer of the plugin so we collaborate on this together. Do you need this MR to be opened as myself to proceed?

tduniec avatar Aug 19 '24 10:08 tduniec

Hi @ionSurf, this plugin was created by @tduniec, could you provide a bit more details as to the background of this migration? I would have expected this more to be done by @tduniec, has the plugin gone unmaintained? If so we generally like to have an issue where we request moving the plugin in the source repo and also include an attribution to the original author for example like this: https://github.com/backstage/community-plugins/tree/main/workspaces/grafana/plugins/grafana#special-thanks--disclaimer

Hello @awanlin. @tduniec was also added as a codeowner when I first created this PR. The plugin is still actively maintained by both, and I took the task to migrate it into the community plugins repo. Would you need for @tduniec name to be mentioned somewhere?

ionSurf avatar Aug 19 '24 11:08 ionSurf

Hi @ionSurf and @tduniec, thanks for the follow up! Now that I know these details I'm more than happy to review this PR as it is and get it merged. Just to confirm once this is migrated the source repo will be marked as archived and same with the package on NPM?

I'll note to be added as a code owner you need to bee an Org Member currently: https://github.com/backstage/community/blob/main/GOVERNANCE.md#organization-member

awanlin avatar Aug 20 '24 13:08 awanlin

Hi @ionSurf and @tduniec, thanks for the follow up! Now that I know these details I'm more than happy to review this PR as it is and get it merged. Just to confirm once this is migrated the source repo will be marked as archived and same with the package on NPM?

I'll note to be added as a code owner you need to bee an Org Member currently: https://github.com/backstage/community/blob/main/GOVERNANCE.md#organization-member

@awanlin thank you for your follow-up. I've already raised an issue with my GitHub handle.

ionSurf avatar Aug 22 '24 15:08 ionSurf

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Sep 28 '24 12:09 github-actions[bot]