community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

ADR plugin - fix image rendering

Open knowacki23 opened this issue 1 year ago • 1 comments

Hey, I just made a Pull Request!

This PR has been re-opened since the previous one have been close due to plugin migration from Backstage Monorepo. Previous PR for context: https://github.com/backstage/backstage/pull/23237

Hey everyone! :) I've stepped upon an use-case in which images for ADR files will not render when they required authentication to access them. Fetching image was done via Backstage Frontend.

With this Pull Request I added a fix which transfers fetching to the Backstage Backend and uses auth token to fetch the image from the source.

Changes are also related to issue #16255

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [x] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

knowacki23 avatar May 20 '24 15:05 knowacki23

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-adr-backend workspaces/adr/plugins/adr-backend patch v0.4.17
@backstage-community/plugin-adr workspaces/adr/plugins/adr patch v0.6.19

backstage-goalie[bot] avatar May 20 '24 15:05 backstage-goalie[bot]

Apologies for the delay in review here - been quite busy on my end and wanted to note that I should have time to take a look at this by 6/1

kuangp avatar May 28 '24 14:05 kuangp

Apologies for the delay in review here - been quite busy on my end and wanted to note that I should have time to take a look at this by 6/1

Thanks! :slightly_smiling_face:

knowacki23 avatar May 28 '24 20:05 knowacki23

Looks like the CI is failing saying that the api-report is out of date - can you make sure to run yarn build:api-reports to commit those changes?

My bad, now it should work :slightly_smiling_face:

knowacki23 avatar Jun 12 '24 09:06 knowacki23

Yay!!! :partying_face: Thank you for your help! :slightly_smiling_face:

knowacki23 avatar Jun 12 '24 14:06 knowacki23