ADR plugin - fix image rendering
Hey, I just made a Pull Request!
This PR has been re-opened since the previous one have been close due to plugin migration from Backstage Monorepo. Previous PR for context: https://github.com/backstage/backstage/pull/23237
Hey everyone! :) I've stepped upon an use-case in which images for ADR files will not render when they required authentication to access them. Fetching image was done via Backstage Frontend.
With this Pull Request I added a fix which transfers fetching to the Backstage Backend and uses auth token to fetch the image from the source.
Changes are also related to issue #16255
:heavy_check_mark: Checklist
Changed Packages
| Package Name | Package Path | Changeset Bump | Current Version |
|---|---|---|---|
| @backstage-community/plugin-adr-backend | workspaces/adr/plugins/adr-backend | patch | v0.4.17 |
| @backstage-community/plugin-adr | workspaces/adr/plugins/adr | patch | v0.6.19 |
Apologies for the delay in review here - been quite busy on my end and wanted to note that I should have time to take a look at this by 6/1
Apologies for the delay in review here - been quite busy on my end and wanted to note that I should have time to take a look at this by 6/1
Thanks! :slightly_smiling_face:
Looks like the CI is failing saying that the api-report is out of date - can you make sure to run
yarn build:api-reportsto commit those changes?
My bad, now it should work :slightly_smiling_face:
Yay!!! :partying_face: Thank you for your help! :slightly_smiling_face: