community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

Add jenkins actions, introduced jenkins client for jenkins server int…

Open robertonav20 opened this issue 11 months ago • 12 comments

Hey, I just made a Pull Request!

This introduces more scaffolder actions into plugin-scaffolder-backend-module-jenkins and are:

  • build
  • copy
  • create
  • create with file
  • destroy
  • disable
  • enable

Thanks in advance!

:heavy_check_mark: Checklist

  • [X] A changeset describing the change and affected packages. (more info)
  • [X] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [X] All your commits have a Signed-off-by line in the message. (more info)

Link to old PR https://github.com/backstage/community-plugins/pull/2134

robertonav20 avatar Feb 14 '25 14:02 robertonav20

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-scaffolder-backend-module-jenkins workspaces/jenkins/plugins/scaffolder-backend-module-jenkins minor v0.8.0

backstage-goalie[bot] avatar Feb 14 '25 14:02 backstage-goalie[bot]

Hi @vinzscam @benjdlambert, i open a new PR because i cannot open the old again.

robertonav20 avatar Feb 14 '25 14:02 robertonav20

Hi @vinzscam, i've updated th PR let me know if i miss something

robertonav20 avatar Feb 21 '25 20:02 robertonav20

Hi @vinzscam, is clear to me thanks for your explanation, i restored previous logic because isn't possible to reuse jenkins client. So if the user specify a serverUrl parameter i will call the specified function. Let me know if is ok now

Thanks in advace :smile:

robertonav20 avatar Mar 08 '25 12:03 robertonav20

Hi @vinzscam, is clear to me thanks for your explanation, i restored previous logic because isn't possible to reuse jenkins client. So if the user specify a serverUrl parameter i will call the specified function. Let me know if is ok now

Thanks in advace 😄

An alternative could have been to invoke buildJenkinsClient() and return a new client, so that we don't have to re-use the old logic

vinzscam avatar Mar 14 '25 22:03 vinzscam

Thanks for the contribution! All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

backstage-goalie[bot] avatar Mar 15 '25 10:03 backstage-goalie[bot]

Hi @vinzscam, now should be all ok

robertonav20 avatar Mar 26 '25 12:03 robertonav20

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Apr 09 '25 18:04 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 03 '25 06:05 github-actions[bot]

Unfortunately some checks are still failing

vinzscam avatar May 06 '25 08:05 vinzscam

Oh I think they are normal... I will check, do you have some suggestions to analyze them?

robertonav20 avatar May 06 '25 13:05 robertonav20

Hi @vinzscam i found the issue and fixed it {930613EF-0F25-4F8F-BB6A-900EBB0E5D14}

PS. i 've added the command prettier:fix to package.json of jenkins folder {A3D89083-C08F-4C52-8DA8-BFFEE1496442}

robertonav20 avatar May 10 '25 00:05 robertonav20

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 24 '25 06:05 github-actions[bot]