Add jenkins actions, introduced jenkins client for jenkins server int…
Hey, I just made a Pull Request!
This introduces more scaffolder actions into plugin-scaffolder-backend-module-jenkins and are:
- build
- copy
- create
- create with file
- destroy
- disable
- enable
Thanks in advance!
:heavy_check_mark: Checklist
- [X] A changeset describing the change and affected packages. (more info)
- [X] Added or updated documentation
- [ ] Tests for new functionality and regression tests for bug fixes
- [ ] Screenshots attached (for UI changes)
- [X] All your commits have a
Signed-off-byline in the message. (more info)
Link to old PR https://github.com/backstage/community-plugins/pull/2134
Changed Packages
| Package Name | Package Path | Changeset Bump | Current Version |
|---|---|---|---|
| @backstage-community/plugin-scaffolder-backend-module-jenkins | workspaces/jenkins/plugins/scaffolder-backend-module-jenkins | minor | v0.8.0 |
Hi @vinzscam @benjdlambert, i open a new PR because i cannot open the old again.
Hi @vinzscam, i've updated th PR let me know if i miss something
Hi @vinzscam, is clear to me thanks for your explanation, i restored previous logic because isn't possible to reuse jenkins client. So if the user specify a serverUrl parameter i will call the specified function. Let me know if is ok now
Thanks in advace :smile:
Hi @vinzscam, is clear to me thanks for your explanation, i restored previous logic because isn't possible to reuse jenkins client. So if the user specify a serverUrl parameter i will call the specified function. Let me know if is ok now
Thanks in advace 😄
An alternative could have been to invoke buildJenkinsClient() and return a new client, so that we don't have to re-use the old logic
Thanks for the contribution! All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.
Hi @vinzscam, now should be all ok
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!
Unfortunately some checks are still failing
Oh I think they are normal... I will check, do you have some suggestions to analyze them?
Hi @vinzscam
i found the issue and fixed it
PS. i 've added the command prettier:fix to package.json of jenkins folder
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!