charts icon indicating copy to clipboard operation
charts copied to clipboard

fix: add namespace to configmap = .Release.Namespace; bump chart version to 1.9.3; update/regen docs

Open nickboldt opened this issue 1 year ago • 2 comments

fix: add namespace to configmap = .Release.Namespace; bump chart version to 1.9.3; update/regen docs

Signed-off-by: Nick Boldt [email protected]

Based on proposed changes in #176 from @IronMage but with DCO fixed and more complete pre-commit hooks applied.

Run standard RH pre-commit checks........................................Passed
Helm Docs................................................................Passed
jsonschema-dereference...................................................Passed

Ref: https://issues.redhat.com/browse/RHIDP-2170

nickboldt avatar Apr 20 '24 12:04 nickboldt

Hey @ChrisJBurns can you explain why the lint test failed here? was it something in my regenerated doc?

nickboldt avatar Apr 22 '24 17:04 nickboldt

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 02 '24 06:05 github-actions[bot]

@nickboldt This is because by default auth is enabled in newer versions of Backstage now. I have raised https://github.com/backstage/charts/issues/186 to resolve this. This should then allow your PR to pass testing.

ChrisJBurns avatar May 04 '24 13:05 ChrisJBurns