catalog: use LoggerService instead of winston Logger in ldap module

[Roshick]

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

• [x] A changeset describing the change and affected packages. (more info)
• [ ] Added or updated documentation
• [ ] Tests for new functionality and regression tests for bug fixes
• [ ] Screenshots attached (for UI changes)
• [x] All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie[bot]]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/plugin-catalog-backend-module-ldap	plugins/catalog-backend-module-ldap	patch	v0.5.34-next.2

[freben]

Note that you'll need to run yarn build:api-reports and commit the results of that too.

Hm this is breaking, isn't it. Then you'll have to bump the changeset to minor. Or alternatively, change the code to accept EITHER a logger service or a winston logger, and it somehow converting it internally if needed.

[Roshick]

@freben as far as I can see this should not be breaking as the new LoggerService is a subset of the old Logger, so for the consumer it shouldn't matter which one they insert as a dependency.

[freben]

Try it in a test. Not sure they're type compatible even if the names are the same. Try to pass in (null as unknown) as WinstonLogger) and see if your editor or typescript complains. I'm not at the computer to check atm

[Roshick]

I'll try it on monday when I'm on my company computer via local linking in our backstage instance.

[github-actions[bot]]

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.27.0 release, scheduled for Tue, 14 May 2024.

[github-actions[bot]]

Uffizzi Cluster pr-24675 was deleted.