backdrop
Remove help icon PNG
As per https://github.com/backdrop/backdrop-issues/issues/6548
Instead of replacing with an SVG (which we don't have an exact one of with grey background), we can remove PNG and use CSS instead (like Basis theme).
@NormPlum where can someone test this? I don't know where this icon appears.
I installed the Styleguide module which shows this with the More Help link.
Basis already overrides it, so you'll need to use the Seven theme to view it.
This issue was discussed in the weekly dev meeting on October 30, https://youtu.be/B2P0CmJMczQ?t=132
From the discussion there is support for this issue, replacing the png with css.
The code looks good but it's a little hard to test since tugboat doesn't appear to allow installing the styleguide module. Will need to test locally.
I've tested this locally by setting up a page that outputs theme('more_help_link', array('url' => 'home')).
LTR looks just fine:
However, RTL is too crowded:
I think that's because you've put 0.4em of margin on the right for LTR, but no extra margin on the left for RTL. You should just override the margin for [dir="rtl"] .more-help-link a:before.
Also, there's no need to keep the old CSS commented out; just remove it. Do we need to keep the help.png file? Perhaps so, contribute modules might be counting on its presence.
With the updated PR, RTL now looks good, too.
Gonna look at some different themes next.
Here's some results for the six most installed contrib Backdrop themes (number of installs in parens):
Bootstrap 5 Lite (335)
Lateral (300)
Gin (293)
Bootstrap Lite (284)
Axioma (202)
Corporate KISS (180)
Lateral is a tiny bit vertically offset, but the two Bootstrap Lites are definitely cut off.
Here's what Bootstrap 5 Lite rendered without this PR:
Seeing as how BSL5 is the most installed theme in all of contrib, it would be worth some further tweaking of CSS to get this to render nicely in the two Bootstraps (and perhaps also Lateral).