backdrop-issues icon indicating copy to clipboard operation
backdrop-issues copied to clipboard
verified publisher icon backdrop

Move `backdrop_var_export()` to common.inc

Open BWpanda opened this issue 5 years ago • 4 comments

Backdrop has a file /core/includes/utility.inc which has just one function in it: backdrop_var_export().

I think this file could just as easily live in /core/includes/common.inc and then we can remove /core/includes/utility.inc altogether. One less file in core! 😃

BWpanda avatar Jan 19 '21 11:01 BWpanda

Seems reasonable.

klonos avatar Jan 20 '21 09:01 klonos

@BWPanda you should warn contribs about that change, at least devel would get damaged:

https://github.com/backdrop-contrib/devel/blob/f5ea492ec97a51d639e99d086ea0dffeea3bbff5/devel.module#L1727

indigoxela avatar Mar 06 '22 10:03 indigoxela

It looks like four total: https://github.com/search?q=org%3Abackdrop-contrib+core%2Fincludes%2Futility.inc&type=code

oadaeh avatar Mar 06 '22 15:03 oadaeh

Should be easy enough to create PRs in those 4 repos then if/when this one is merged.

ghost avatar Mar 06 '22 19:03 ghost