backdrop-ops
Node title + Readme not (always) updated with each release
Another example of this is the Ubercart Price per Role module: b.org module page = "Price per Role" module .info file = "Ubercart Price per Role"
Would be great if the b.org node title and description (pulled from README) were updated with each release.
Once this is working, we can start to gently nudge module developers to adhere to standard capitalization rules, follow other naming conventions (e.g., wrt Ubercart modules), etc. (Mea culpa; I'd like to see my own past mistakes go away!)
The description of the node would need to get updated, also, on each release. I updated the readme of the module Catalan Countries but it doesn't get updated in the node either.
The project_github module has code in project_github_node_presave() (erroneously called hook_node_insert() in its docblock) that updates from the README whenever the project node is saved. And I just verified by editing the Catalan Countries module, making no changes, but saving it, that the README file was updated (the typo that was fixed in GH became fixed on B).
So, it's a little puzzling that the README isn't being updated (and it clearly wasn't). borg_github_github_project_release_validate() updates and saves the project node; I would have thought that would invoke the hook and update the README.
But meanwhile, it does look like that's the function where to insert updating the title from the info file (which got parsed earlier in the function).
More investigation to do...
is borg_github_github_project_release_validate maybe updating the project release node, but not the project node itself? Maybe it just updates a property on the project node, without saving the whole node?
The last lines of borg_github_github_project_release_validate() are
// Save project node.
$project_node->save();
And $project_node is set early in the function by
$project_node = node_load($release_node->project_release['project_nid']);
Just to confuse things further, I just did a new release of the Bootstrap5 Lite module in which the README file was updated, and the new README is indeed showing correctly at https://backdropcms.org/project/bootstrap5_lite. So the README gets updated at least sometimes.