circuitpython-tm1637 icon indicating copy to clipboard operation
circuitpython-tm1637 copied to clipboard

Add support for six digit displays

Open IrregularShed opened this issue 2 years ago • 2 comments

Six digit TM1637 displays have an awkward mapping when compared to the four digit variety.

(This is my first CircuitPython library code ever, and I'm a Python n00b, so I hope it's OK.)

IrregularShed avatar May 22 '23 13:05 IrregularShed

Hi! Thanks for the PR. The problem is, I cannot test it. But it looks ok. The only change I am requesting is that you put your code in a separate file. The reason is the memory constrains of small MCUs. I was already fighting with the existing code with my SAMD21 (the original micropython-code has some more functions). Putting the new class in a separate file will allow users of the small 4-digit version only to load the relevant code.

bablokb avatar May 23 '23 14:05 bablokb

👍 I'll switch things around as soon as I get the chance, I hadn't considered tiny microcontrollers. (I only really use RP2040 and ESP32-S2 boards so the space isn't as much of a premium.)

IrregularShed avatar May 23 '23 15:05 IrregularShed