node-xmlrpc icon indicating copy to clipboard operation
node-xmlrpc copied to clipboard

Send content-length header in method responses

Open chfritz opened this issue 9 years ago • 7 comments

  • unlike method calls (client), method responses (server) did not yet send content-length headers. This was causing problem with at least one client (ros's turtlesim, in the context of rosnodejs: publishing to /turtlt1/cmd_vel had no effect on the turtle). This commit fixes that.

chfritz avatar Jun 28 '16 04:06 chfritz

Hi, there! Are there any stop factors for merging this PR?

atn18 avatar Jun 04 '19 14:06 atn18

@agladkov We would love to see this patch pushed. Are there any actual objections?

rudicus avatar Nov 18 '19 21:11 rudicus

I have no objections. I have not merge perms :) Question to @baalexander

atn18 avatar Nov 19 '19 06:11 atn18

@baalexander @patricklodder Any chance you guys can merge this and update the published npm package? We are dependent on a downstream package (https://www.npmjs.com/package/rosnodejs) and I would hate to have to fork both projects for a 1 line change. Thanks.

rudicus avatar Nov 19 '19 16:11 rudicus

I need that change as well!

cr1979 avatar Mar 05 '23 13:03 cr1979

@cr1979 We've forked the package a while ago and published a new one with the fixes we needed. You can find it here: https://www.npmjs.com/package/xmlrpc-rosnodejs. Just change xmlrpc to xmlrpc-rosnodejs everywhere.

chfritz avatar Mar 05 '23 16:03 chfritz

@cr1979 We've forked the package a while ago and published a new one with the fixes we needed. You can find it here: https://www.npmjs.com/package/xmlrpc-rosnodejs. Just change xmlrpc to xmlrpc-rosnodejs everywhere.

@chfritz perfect thank you!

cr1979 avatar Mar 05 '23 16:03 cr1979