vscode-csproj icon indicating copy to clipboard operation
vscode-csproj copied to clipboard

Extension does not properly detect filenames beginning with '$' if they're already in a csproj file

Open isochronous opened this issue 8 years ago • 3 comments

We occasionally name files with a '$' at the beginning of the name so that they're guaranteed to show up first in any alphanumeric sort. The problem is that the extension doesn't pick up on files like that already in the .csproj file. Any time I open any files with a filename beginning with '$', I get the "file is not in the csproj file, would you like to add it?" message, despite said file definitely already being there. I'm assuming it's a regex issue.

isochronous avatar Apr 27 '17 18:04 isochronous

Actually seems to be an XPATH issue:

https://github.com/azz/vscode-csproj/blob/master/src/csproj.ts#L34.

Which will interpolate to "./ItemGroup/*[@Include='path/to/$file']".

I'll have to dig through the elementtree package to figure this one out.

azz avatar Apr 28 '17 01:04 azz

Tried to reproduce, but failed. Are you using the default settings, or do you have an include/exclude regex set? If so could you post the config?

azz avatar Apr 28 '17 01:04 azz

I'm just using the defaults. I'll see if I can reproduce it with a different csproj file. On Thu, Apr 27, 2017 at 9:27 PM Lucas Azzola [email protected] wrote:

Tried to reproduce, but failed. Are you using the default settings, or do you have an include/exclude regex set? If so could you post the config?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/azz/vscode-csproj/issues/8#issuecomment-297882824, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvR0S-DrNaEeSg3vZ64jZ5Ln54cZVv8ks5r0UB6gaJpZM4NKoBe .

isochronous avatar Apr 28 '17 02:04 isochronous