offset icon indicating copy to clipboard operation
offset copied to clipboard

macOS 10.15.x support?

Open codewisdom opened this issue 6 years ago • 3 comments

Has anyone tested this with 10.15.x (Catalina) by any chance?

codewisdom avatar Dec 21 '19 23:12 codewisdom

I have been testing offset in Catalina. Similar to Mojave, you need to make a change to the OS check in the python script to allow it to run. So far no issues.

I run this command packed as a postinstall script when I deploy offset using an MDM solution.

sed -i "-bak" "s/(mac_version == '13')/(mac_version == '13') or (mac_version == '14') or (mac_version == '15')/g" /usr/local/offset/offset

chadnielsen avatar Jan 09 '20 17:01 chadnielsen

@chadnielsen, thanks for sharing. Instead of making that change for just your org, do you want to make a PR and have that change reflected for everyone?

Maybe a >= instead of ==?

I haven't used Offset in a while, so it'd probably be better to have someone using it make that PR, but I'm happy to review and approve.

aysiu avatar Jan 09 '20 18:01 aysiu

What are you seding, by the way? I took a look at the code in master, and it already seems to be greater than or equal to: https://github.com/aysiu/offset/blob/master/offset#L218

aysiu avatar Jan 10 '20 03:01 aysiu