jooq-modelator icon indicating copy to clipboard operation
jooq-modelator copied to clipboard

chore(deps): Bump dependencies and use docker-login action

Open ursjoss opened this issue 1 year ago • 3 comments

Resolves #22

  • Bumps almost all versions of dependencies to the current versions - except liquibase, where I only bumped to the latest 3.x version (3.10.3), but didn't invest into migrating to liquibase-4.x.
  • minimum JRE version is now 17
  • Removes obsolete jaxb dependencies
  • updates the github action versions used
  • set up the github action CI job to log into dockerhub (requires you to add the secrets to the github action, see comment below) and to actively pull the docker containers for postgres and maridb.

ursjoss avatar Mar 24 '24 11:03 ursjoss

Will have to investigate, why it fails. The check is passing locally. Will check it out later...

ursjoss avatar Mar 24 '24 11:03 ursjoss

@ayedo Pulling the docker container in the github action requires a login nowadays. I set the same PR up in my own fork of this repo and got it to work by adding two secrets to the github repo:

  • DOCKERHUB_USERNAME containing your username for the dockerhub login
  • DOCKERHUB_TOKEN containing the password

image

Here's the link to the passing PR: https://github.com/ursjoss/jooq-modelator/pull/1

ursjoss avatar Mar 24 '24 16:03 ursjoss

@ayedo What's your take on the PR? Would you be willing to try configuring the docker hub access to get the PR to pass?

ursjoss avatar Apr 08 '24 17:04 ursjoss