Cross-platform support and a workaround for consult chars outside unicode in native module
I have a couple minor changes suggested in this PR:
-
*u8string literals are not available in C99 (cpp references says since C11), so bumpedC_STANDARD -
sysinfo/get_nprocs()is unavailable on macOS so I'm usingsysconfto get processor count. - Added
hotfuzz--fix-tofu-charsto add as advice on native filtering to fix issues with consult-multi tofu characters outside unicode range, e.g. #12, used like:
(advice-add 'hotfuzz--filter-c :around #'hotfuzz--fix-tofu-chars)
The consult workaround has some helper functions from https://github.com/magnars/dash.el which I pulled in to avoid having a whole dependency on dash, but can also refactor them and add a dependency if you think it's worth it.
FWIW, this advice-add fixed the breakage with consult for me nicely. It seems it wasn't pulled into the main hotfuzz codebase, though.
Codecov Report
Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.
Project coverage is 85.85%. Comparing base (
6223294) to head (9b1cac9).
| Files | Patch % | Lines |
|---|---|---|
| hotfuzz.el | 59.09% | 9 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 93.50% 85.85% -7.65%
==========================================
Files 1 1
Lines 77 99 +22
==========================================
+ Hits 72 85 +13
- Misses 5 14 +9
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.