flowgger icon indicating copy to clipboard operation
flowgger copied to clipboard

fix: warn when cargo clippy

Open DaviRain-Su opened this issue 4 years ago • 7 comments

Issue #, if available:

Description of changes:

fix: warn when cargo clippy, and fix some code.

DaviRain-Su avatar Mar 30 '21 17:03 DaviRain-Su

Thanks for your contribution. The tests seem to fail due to a missing package though. Can you check that ?

vche avatar Mar 30 '21 18:03 vche

Thanks for your contribution. The tests seem to fail due to a missing package though. Can you check that ?

Ok, This test seem before have already build error.

DaviRain-Su avatar Mar 31 '21 01:03 DaviRain-Su

Thanks for your contribution. The tests seem to fail due to a missing package though. Can you check that ?

I have find some solution, but I can't setting configuation, https://github.com/rust-embedded/cross/issues/404. Can you help me.

DaviRain-Su avatar Mar 31 '21 03:03 DaviRain-Su

Of course. I will take look later today or tomorrow.

vche avatar Mar 31 '21 13:03 vche

Of course. I will take look later today or tomorrow.

ye, thx.

DaviRain-Su avatar Mar 31 '21 15:03 DaviRain-Su

Thanks for your patience. Just a quick update here, openssl is indeed missing in the arm platforms, and was before your pull request.

I am working on it, and will fix it, but I am struggling finding enough time to deal with this at the moment. Let me know if you that is blocking you.

vche avatar Apr 14 '21 16:04 vche

Thanks for your patience. Just a quick update here, openssl is indeed missing in the arm platforms, and was before your pull request.

I am working on it, and will fix it, but I am struggling finding enough time to deal with this at the moment. Let me know if you that is blocking you.

Thx, I'm ok.

DaviRain-Su avatar Apr 15 '21 02:04 DaviRain-Su