awslabs
Prevent a batch of messages going over the threshold
Issue #24
Description of changes:
I noticed that the sum of the message sizes in the batch could still go over the threshold, so I've added support, and tests, for this to be prevented. I'll comment on the PR in order to explain the changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Hey, can this one get any attention? It's a real issue with the client that needs to be addressed.
Take a fork of my version and use that. It's what we did with my last client. AWS tends not to fix these releases.
@ashleyfrieze i got my PR merged here few month ago, so there is some hope this one will also be reviewed if we will create some noise here :)
@ashleyfrieze It looks like this had been approved previously? but has since conflicts now. Is this something that could be re-visited to push? Add another to the list of projects it has bitten trying to use sendBatch
@ymartin we solved this problem - the lack of merge - by building my fork and publishing it to a local repo.
That was back in 2019 or so.
I haven’t the time to pick this up myself.
However, if you want to get a commit into shape on your own fork and then ask me to make my code look like that commit behind this PR, I’m happy to do so.
It’ll take a little bit of git magic, but it is easy to do.
@ymartin I thought I'd have ago at resolving the conflicts. However, as I feared, the problem is made more complex by the fact that the latest version has switched to a newer AWS SDK.
So, which SDK do we want to use for this fix? Probably SDK v2?