recipes-sdk/*: remove condition on BUILD_SHARED_LIBS in cmake files
BUILD_SHARED_LIBS controls how AWS SDK libraries get built and packaged. Since BUILD_SHARED_LIBS defaults to ON during build, the resulting binary packages only contain dynamic libraries. That means a condifion on this variable in the corresponding cmake file in the binary package makes no sense. Moreover, if another component that uses AWS SDK libraries sets its BUILD_SHARED_LIBS variable to OFF, it will fail as there are no static AWS SDK libs provided.
Fixes: https://github.com/aws/meta-aws/issues/178
Signed-off-by: Denys Dmytriyenko [email protected]
Hi @denix0 we are asking that PRs be made to master-next
I am also asking @justinboswell to help look at this so we don't need to do the cmake modifications. Please stay tuned ok?
@rpcme any updates?
I am still talking with the service team, @denix0. I want to fix this upstream. I hope you understand. Is this blocking you? If it's blocking we will huddle to see it as an intermediate solution until we can get a long term solution in place.
@denix0 this is now fixed upstream by the various aws iot libs, by not abusing the BUILD_SHARED_LIBS variable. Thank you for the patience!