aws
Shlex quote
feature: shlex quote asyncio run
Issue #, if available:
#128
Description of changes:
Add shlex.quote to asyncio run. Arguments are not escaped so JSON hyperparameters are not passed correctly.
Testing done:
Ran docker image in sagemaker before and after change. Hyperpameters with spaces are passed to user script as a single token.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
- [x] I have read the CONTRIBUTING doc
- [x] I used the commit message format described in CONTRIBUTING
- [x] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
- [x] I have updated any necessary documentation, including READMEs
Tests
- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
- [x] I have checked that my tests are not configured for a specific region or account (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
AWS CodeBuild CI Report
- CodeBuild project: sagemaker-training-toolkit-pr
- Commit ID: 4e87e01ba630589b5149738da044bd1580d31bcf
- Result: FAILED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
AWS CodeBuild CI Report
- CodeBuild project: sagemaker-training-toolkit-pr
- Commit ID: f4227bdb29ee00366ef566677ffbb114df8433c3
- Result: FAILED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository