sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

Add new Triton DLC URIs

Open nikhil-sk opened this issue 1 year ago • 1 comments

Issue #, if available:

Description of changes:

  1. Starting Triton version 23.12, sagemaker tritonserver is available in a different set of accounts, similar to other model servers such as djl-serving, torchserve etc. i.e. original DLC accounts, as opposed to SageMaker Neo accounts. Triton on SageMaker will be available on both Neo accounts and new DLC accounts until v23.05. After v23.05, Triton will only be available in the new DLC URIs (i.e. accounts listed in this PR).
  2. Adding the account id and region map for DLC accounts.

Testing done:

 pytest -s tests/unit/sagemaker/image_uris/test_sagemaker_tritonserver.py 

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [x] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nikhil-sk avatar Feb 16 '24 22:02 nikhil-sk

cc : @mufaddal-rohawala for review

nikhil-sk avatar Feb 16 '24 22:02 nikhil-sk

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 285a10e165d12e8cfb48f71d0dcfece20e76195c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 26 '24 22:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 761b92c3a10fa997d1821844695802bb17e9934c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 26 '24 23:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 761b92c3a10fa997d1821844695802bb17e9934c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 26 '24 23:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 761b92c3a10fa997d1821844695802bb17e9934c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 00:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 761b92c3a10fa997d1821844695802bb17e9934c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 00:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 761b92c3a10fa997d1821844695802bb17e9934c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 01:02 mufaddal-rohawala

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.16%. Comparing base (8b206ba) to head (d0278a9). Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4432      +/-   ##
==========================================
+ Coverage   86.94%   87.16%   +0.22%     
==========================================
  Files        1203      387     -816     
  Lines      107211    35811   -71400     
==========================================
- Hits        93211    31215   -61996     
+ Misses      14000     4596    -9404     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 27 '24 01:02 codecov[bot]

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: d0278a980fcc1bd306c68b1c9c9b07547981ddd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 21:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: d0278a980fcc1bd306c68b1c9c9b07547981ddd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 21:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: d0278a980fcc1bd306c68b1c9c9b07547981ddd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 22:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: d0278a980fcc1bd306c68b1c9c9b07547981ddd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 22:02 mufaddal-rohawala

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: d0278a980fcc1bd306c68b1c9c9b07547981ddd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala avatar Feb 27 '24 22:02 mufaddal-rohawala