sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

pass session to image_uris.retrieve() within huggingface get_llm_image_uri() func

Open Adamwgoh opened this issue 2 years ago • 1 comments

Describe the bug Currently image_uri retrieval always uses default jumpstart. For those who wants to use that function and passes a sagemaker session with profiles setup , it will not be received when running image_uris.retrieve(). the session is currently only used to retrieve the region of the session only

To reproduce A clear, step-by-step set of instructions to reproduce the bug.

Expected behavior sagemaker-python-sdk/src/sagemaker/huggingface

    if backend == "huggingface":
        return image_uris.retrieve(
            "huggingface-llm",
            region=region,
            version=version,
            image_scope="inference",
            sagemaker_session=session
        )

.

Adamwgoh avatar Oct 29 '23 08:10 Adamwgoh

If permitted I'd like to contribute to add this in via a PR , It'll be my first time trying to contribute and would like to take the time to run through the guidelines and submit the PR

Adamwgoh avatar Oct 29 '23 08:10 Adamwgoh