sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard
verified publisher icon aws

audit docstring and function signature arg type for workflow classes

Open jerrypeng7773 opened this issue 3 years ago • 16 comments

Issue #, if available:

Description of changes:

audit doc string and function and constructor args type mismatch.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [x] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jerrypeng7773 avatar Mar 19 '22 00:03 jerrypeng7773

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5e12687e0bbf1a40eca3e0364d1090d8a2de867d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 19 '22 00:03 sagemaker-bot

Codecov Report

Merging #3013 (1e23017) into master (10f1e24) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3013   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         197      197           
  Lines       16668    16678   +10     
=======================================
+ Hits        14898    14908   +10     
  Misses       1770     1770
Impacted Files Coverage Δ
src/sagemaker/session.py 70.52% <ø> (ø)
src/sagemaker/workflow/pipeline.py 88.15% <ø> (ø)
src/sagemaker/workflow/utilities.py 100.00% <ø> (ø)
src/sagemaker/workflow/_repack_model.py 100.00% <100.00%> (ø)
src/sagemaker/workflow/_utils.py 95.96% <100.00%> (+0.13%) :arrow_up:
src/sagemaker/workflow/callback_step.py 97.95% <100.00%> (ø)
src/sagemaker/workflow/check_job_config.py 93.93% <100.00%> (+0.18%) :arrow_up:
src/sagemaker/workflow/clarify_check_step.py 97.48% <100.00%> (ø)
src/sagemaker/workflow/condition_step.py 100.00% <100.00%> (ø)
src/sagemaker/workflow/emr_step.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10f1e24...1e23017. Read the comment docs.

codecov-commenter avatar Mar 19 '22 00:03 codecov-commenter

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 5e12687e0bbf1a40eca3e0364d1090d8a2de867d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 19 '22 01:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 5e12687e0bbf1a40eca3e0364d1090d8a2de867d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 19 '22 01:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: a66a36f51922eafd23d48e93e859bd4220f1c7ee
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 26 '22 00:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: a66a36f51922eafd23d48e93e859bd4220f1c7ee
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 26 '22 00:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: a66a36f51922eafd23d48e93e859bd4220f1c7ee
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 26 '22 00:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 540990c61c5fec75e931f8b60136b270b5e74553
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 31 '22 19:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 540990c61c5fec75e931f8b60136b270b5e74553
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 31 '22 19:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 540990c61c5fec75e931f8b60136b270b5e74553
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Mar 31 '22 19:03 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 447b99762aac66bf2b843407baa00cca580d16f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Apr 05 '22 18:04 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 447b99762aac66bf2b843407baa00cca580d16f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Apr 05 '22 19:04 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 1e2301706a4167493ca3860b86b855a03d90c19d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Apr 08 '22 20:04 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1e2301706a4167493ca3860b86b855a03d90c19d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Apr 08 '22 21:04 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 1e2301706a4167493ca3860b86b855a03d90c19d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Apr 08 '22 22:04 sagemaker-bot

Hi @jerrypeng7773 can you please take a look at the merge conflicts

BasilBeirouti avatar Aug 18 '22 06:08 BasilBeirouti

@jerrypeng7773 , can you please take a look at the merge conflicts.

vikas0203 avatar Nov 30 '22 23:11 vikas0203

thanks for contributing but this code change has been pending for too long. Please reopen if this change is still relevant!

mufaddal-rohawala avatar May 09 '23 01:05 mufaddal-rohawala