sagemaker-inference-toolkit icon indicating copy to clipboard operation
sagemaker-inference-toolkit copied to clipboard

fix: write the mms config file to a subdir of base_dir instead of /etc

Open ahakanbaba opened this issue 5 years ago • 4 comments

fix #72

Issue #, if available: 72

Description of changes:

write the mms config file to a subdir os base_dir instead of /etc

Testing done:

unit tests pass on local

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [X] I have read the CONTRIBUTING doc
  • [X] I used the commit message format described in CONTRIBUTING
  • [ ] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • [x] I have updated any necessary documentation, including READMEs

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [X] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ahakanbaba avatar Oct 30 '20 02:10 ahakanbaba

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: 9f1a10e5a7fe3ae8909aad4ad5b542065b969d36
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 30 '20 03:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: f76b245f68761a4d77c376270a0860a335c400f5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 30 '20 04:10 sagemaker-bot

Dear Maintainers. We would appreciate very much if you could add some comments to this PR ?

ahakanbaba avatar Dec 14 '20 07:12 ahakanbaba

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: 3c03b2e6fdd8257d4613b798369f7a7d747f0d31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Jan 15 '21 23:01 sagemaker-bot